Re: 2.5.22: FB_VESA - early crash in fbcon_cursor()

From: James Simmons (jsimmons@transvirtual.com)
Date: Tue Jun 18 2002 - 12:15:08 EST


> Looks like the dispsw isn't being set and you're running into the NULL
> dereference in fbcon_cursor() upon trying to dereference it.. it looks like
> fbgen.c is the culprit here, as it never sets display->dispsw if we aren't in
> 24-bpp or have FBCON_HAS_ACCEL set..
>
> James, what's the point of th FBCON_HAS_ACCEL ifdef? It looks like all the
> accel wrapper code does is provide a wrapper to the fillrect, imageblit, and
> copyarea routines -- if the driver doesn't have accelerated ones to provide
> for itself, it just uses the cfb_fillrect/imageblit/copyarea as a fallback,
> thus it should _always_ be safe to call them.
>
> If that's not the case, we'll have to re-introduce the FBON_HAS_CFBx
> brain-damage in gen_set_disp() to keep dispsw happy.

Your right. Alot of people have been bitten by that. Especially since
people are so use to manually setting the CFB stuff. Patch applied to BK
tree.

   . ---
   |o_o |
   |:_/ | Give Micro$oft the Bird!!!!
  // \ \ Use Linux!!!!
 (| | )
 /'\_ _/`\
 \___)=(___/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:16 EST