Re: [patch] scheduler bits from 2.5.23-dj1

• Next message: Dave Jones: "Re: [patch] scheduler bits from 2.5.23-dj1"
• Previous message: Ingo Molnar: "[patch] scheduler bits from 2.5.23-dj1"
• In reply to: Ingo Molnar: "[patch] scheduler bits from 2.5.23-dj1"
• Next in thread: Andrea Arcangeli: "Re: [patch] scheduler bits from 2.5.23-dj1"
• Reply: Andrea Arcangeli: "Re: [patch] scheduler bits from 2.5.23-dj1"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 2002-06-19 at 16:35, Ingo Molnar wrote:

> the scheduler optimisation in 2.5.23-dj1, from James Bottomley, look fine
> to me. I did some modifications:

Nice.

> +static inline unsigned int task_cpu(struct task_struct *p)
> +static inline unsigned int set_task_cpu(struct task_struct *p, unsigned int cpu)

Technically, shouldn't we make these `unsigned long' ?

I know on x86 we store cpu as a `u32' so it does not matter per se, but
in reality it is an unsigned long and other architectures may export it
as such.

Further, we compare and set it against the various CPU bitmaps and they
are all `unsigned long' and we do shifts against 1UL ...

        Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Dave Jones: "Re: [patch] scheduler bits from 2.5.23-dj1"
• Previous message: Ingo Molnar: "[patch] scheduler bits from 2.5.23-dj1"
• In reply to: Ingo Molnar: "[patch] scheduler bits from 2.5.23-dj1"
• Next in thread: Andrea Arcangeli: "Re: [patch] scheduler bits from 2.5.23-dj1"
• Reply: Andrea Arcangeli: "Re: [patch] scheduler bits from 2.5.23-dj1"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:20 EST