Attached is a small cleanup of the parameter parsing in the ide driver.
This patch replaces some of the string parsing code with get_options()
and it starts cleaning up the code that checks for specific chipsets.
I tried to keep the chipset error checking exactly as it was before, and
now the remaining code looks a little strange. It does something like
this:
if (parameter is a chipset name) {
if (chipset type is already defined for selected port)
goto bad_option;
if ((chipset parameter != dc4030) && (hw!=ide0) )
goto bad_channel;
if ((chipset parameter != dc4030) &&
chipset type is already defined for ide1)
goto bad_option;
}
Can some of this be removed? It would allow the remaining code to be
simplified..
Gerald
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:21 EST