Re: [PATCH] Split up agpgart into per implementation files.

From: Dave Jones (davej@suse.de)
Date: Thu Jun 20 2002 - 09:06:12 EST

On Thu, Jun 20, 2002 at 02:49:45PM +0200, Nicolas Aspert wrote:

> Definitely a good idea !
> The code is much easier to read.

Exactly. It also becomes a little easier to slot in support
for new vendors, than navigating a 120kb .c file.

> For those interested in trying this with 2.4, here is an adaptation of
> the patch for 2.4.19-pre10-ac2 . I did not include neither the changes
> made in 2.5.23 (at least they should not be here), nor the intel 460
> stuff (not present in 2.4).

Thanks for doing this.. I goofed the Makefile, and it doesn't build
correctly as modules under 2.5. Fixed one is at http://www.codemonkey.org.uk/Makefile
Just drop it into drivers/char/agp/ after applying my patch.
Due to build system differences, I'm not sure if your 2.4 patch also
suffers the same problem..

Oh, and agp.h has the definition of PFX below code which uses it,
and should be moved around..

        Dave 

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Jun 23 2002 - 22:00:22 EST