Re: [PATCH] 2.5.24 : drivers/scsi/inia100.c

From: Francois Romieu (romieu@cogenit.fr)
Date: Mon Jun 24 2002 - 01:30:36 EST

Next message: Francois Romieu: "Re: [PATCH] 2.5.24 : drivers/net/tlan.c"
Previous message: David S. Miller: "Re: RFC: turn scatterlist into a linked list, eliminate bio_vec"
Next in thread: Frank Davis: "Re: [PATCH] 2.5.24 : drivers/scsi/inia100.c"
Reply: Frank Davis: "Re: [PATCH] 2.5.24 : drivers/scsi/inia100.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Greetings,

Frank Davis <fdavis@si.rr.com> :
> Hello all,
> This patch adds the DMA mapping check (1st step for
> Documentation/DMA-mapping.txt compliance). Please review.

- please take a look at Documentation/CodingStyle
- if pci_set_dma_mask() fails, the driver shouldn't go on as if nothing
happened. See what other drivers do (net/acenic.c for example)
- the interesting part of DMA mapping conversion is more a matter of
memory descriptor handling (and phys_to_virt/friends removal)

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Francois Romieu: "Re: [PATCH] 2.5.24 : drivers/net/tlan.c"
Previous message: David S. Miller: "Re: RFC: turn scatterlist into a linked list, eliminate bio_vec"
Next in thread: Frank Davis: "Re: [PATCH] 2.5.24 : drivers/scsi/inia100.c"
Reply: Frank Davis: "Re: [PATCH] 2.5.24 : drivers/scsi/inia100.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jun 30 2002 - 22:00:06 EST