Knut J Bjuland wrote:
> Your patch fix my problem with the new i815 code. I run it through a quake3 test and it is as fast as the old
> code,
> Agpgart is now able to determine aperture size, I think you nailed this problem. Thank you for your patch, hope
> it get in Linux 2.4.19.
>
Ok that sounds like one bug killed ;-), so I guess this should go in for
2.4.19-rc2 ...
Marcelo, please apply (patch is against 2.4.19-rc1). I know that Alan
and Dave have also similar parts in their trees and they are likely to
suffer the same problem.
Thanks Knut for pointing the problem (although it was present in
2.4.19-pre10-ac2 already for sure...)
Best regards
Nicolas.
-- Nicolas Aspert Signal Processing Institute (ITS) Swiss Federal Institute of Technology (EPFL)
diff -Nru linux-2.4.19-rc1.clean/drivers/char/agp/agpgart_be.c linux-2.4.19-rc1/drivers/char/agp/agpgart_be.c --- linux-2.4.19-rc1.clean/drivers/char/agp/agpgart_be.c Thu Jun 27 09:07:04 2002 +++ linux-2.4.19-rc1/drivers/char/agp/agpgart_be.c Thu Jun 27 10:53:47 2002 @@ -1402,6 +1402,12 @@ aper_size_info_8 *values; pci_read_config_byte(agp_bridge.dev, INTEL_APSIZE, &temp); + + /* Intel 815 chipsets have a _weird_ APSIZE register with only + * one non-reserved bit, so mask the others out ... */ + if (agp_bridge.type == INTEL_I815) + temp &= (1 << 3); + values = A_SIZE_8(agp_bridge.aperture_sizes); for (i = 0; i < agp_bridge.num_aperture_sizes; i++) {
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Jun 30 2002 - 22:00:11 EST