Re: [PATCH] ATA: cleanup of channel->autodma flags usage

From: Bartlomiej Zolnierkiewicz (B.Zolnierkiewicz@elka.pw.edu.pl)
Date: Thu Jun 27 2002 - 09:59:22 EST


On 27 Jun 2002, Kees Bakker wrote:

> >>>>> "Bartlomiej" == Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl> writes:
>
> Bartlomiej> incremental to generic ATA PCI auto-dma patches...
> [...]
> Bartlomiej> - remove ATA_F_NOAUTODMA flag from aec62xx.c, hpt34x.c,
> Bartlomiej> sis5513.c and via82cxxx.c drivers, it's use was bogus
> Bartlomiej> in these drivers
>
> Bartlomiej> only two usages of ATA_F_NOAUTODMA are left (in ide-pci.c),
> Bartlomiej> probably they can alse be removed due to fact that drivers
> Bartlomiej> should disable autodma not ide-pci (i.e. hpt34x)
> [...]
>
> That should say: ATA_F_NOADMA

Yep, thanks.

> I have removed ATA_F_NODMA in ide-pci.c for my VIA8233
> (PCI_DEVICE_ID_VIA_82C586_1). So far it has not failed (using 2.5.20).

Because its usage is bogus and you probably use via82cxxx.c anyway :)

>
> --- linux-2.5.20/drivers/ide/ide-pci.c~ Mon Jun 3 14:49:59 2002
> +++ linux-2.5.20/drivers/ide/ide-pci.c Fri Jun 7 18:52:50 2002
> @@ -742,8 +742,7 @@
> {
> vendor: PCI_VENDOR_ID_VIA,
> device: PCI_DEVICE_ID_VIA_82C586_1,
> - bootable: ON_BOARD,
> - flags: ATA_F_NOADMA
> + bootable: ON_BOARD
> },
> {
> vendor: PCI_VENDOR_ID_TTI,
>
> - Kees
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jun 30 2002 - 22:00:12 EST