Re: 2.4.19-rc1 broke OSF binaries on alpha

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Mon Jul 01 2002 - 11:17:10 EST


Kurt Garloff wrote:
> Hi Ivan, Alan, Marcelo,
>
> On Sun, Jun 30, 2002 at 03:50:58AM +0400, Ivan Kokshaysky wrote:
>
>>On Sat, Jun 29, 2002 at 03:28:50AM +0100, Alan Cox wrote:
>>
>>>Please back it back in. The bug is the Alpha port. Alpha needs its own OSF
>>>readv/writev entry point which masks the top bits.
>>
>>Ouch. The new entry point just because of this?!
>>Marcelo, if you're going to back in that patch, please apply
>>the following on the top of it.
>
>
> This patch indeed makes acroread & netscape work again on my alpha. Nice
> spotting.
> Don't we know about the type of binary? (Like personality ...)
> So we could use something like
> ssize_t len
> #ifdef __alpha__
> if (current->personality == DEC_OSF_OLD)
> len = (int) iov[i].iov_len;
> else
> len = (ssize_t) iov[i].iov_len;
> #else
> len = (ssize_t) iov[i].iov_len;
> #endif
>
> Not really beautiful, but working for all cases.

That's a good point.

FWIW we have Mozilla 1.0.x working just fine on Alpha, so I don't mind
second-classing, or making optional, OSF/1 binary support.

It _should_ be possible to correctly support SuSv3 and OSF/1 binaries
simultaneously.

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Jul 07 2002 - 22:00:07 EST