Re: [PATCH] preempt-safe load_LDT

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sat Jul 20 2002 - 15:42:27 EST

Next message: Rik van Riel: "Re: [PATCH][1/2] return values shrink_dcache_memory etc"
Previous message: Linus Torvalds: "Re: [PATCH] generalized spin_lock_bit"
In reply to: Robert Love: "[PATCH] preempt-safe load_LDT"
Next in thread: Ingo Molnar: "Re: [PATCH] preempt-safe load_LDT"
Reply: Ingo Molnar: "Re: [PATCH] preempt-safe load_LDT"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 20 Jul 2002, Robert Love wrote:
>
> Attached patch makes load_LDT preempt-safe per our off-list discussion.

It's buggy. It calls smp_processor_id() outside the preemption window, see
"load_LDT()".

I'd suggest making it use get/put_cpu() and to avoid the header file
dependencies moving it away from desc.h and into ldt.c instead.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Rik van Riel: "Re: [PATCH][1/2] return values shrink_dcache_memory etc"
Previous message: Linus Torvalds: "Re: [PATCH] generalized spin_lock_bit"
In reply to: Robert Love: "[PATCH] preempt-safe load_LDT"
Next in thread: Ingo Molnar: "Re: [PATCH] preempt-safe load_LDT"
Reply: Ingo Molnar: "Re: [PATCH] preempt-safe load_LDT"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:33 EST