Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update

From: Francois Romieu (romieu@cogenit.fr)
Date: Mon Jul 22 2002 - 01:35:48 EST

Next message: Andrew Morton: "Re: [PATCH][1/2] return values shrink_dcache_memory etc"
Previous message: Zhang Fuxin: "Re: problem with eepro100 NAPI driver"
In reply to: support: "Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update"
Next in thread: support: "Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update"
Reply: support: "Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

support <support@promise.com.tw> :
[...]
> We don't occur Oops you said, Please check your patch rule again.

There's a side effect with your macro. Let's expand it:

+#define set_2regs(a, b) \
+ OUT_BYTE((a + adj), indexreg); \
+ OUT_BYTE(b, datareg);
[...]
+ if (speed == XFER_UDMA_2)
+ set_2regs(thold, (IN_BYTE(datareg) & 0x7f));

        if (speed == XFER_UDMA_2)
                OUT_BYTE((thold + adj), indexreg);
        OUT_BYTE((IN_BYTE(datareg) & 0x7f), datareg);

Do you see the problem ?

-- 
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Andrew Morton: "Re: [PATCH][1/2] return values shrink_dcache_memory etc"
Previous message: Zhang Fuxin: "Re: problem with eepro100 NAPI driver"
In reply to: support: "Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update"
Next in thread: support: "Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update"
Reply: support: "Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:37 EST