Re: [PATCH] 2.5.27 read_write

From: Alan Cox (alan@lxorguk.ukuu.org.uk)
Date: Mon Jul 22 2002 - 11:55:23 EST

Next message: Arnaldo Carvalho de Melo: "Re: [2.5.27] Oops in tcp_v6_get_port"
Previous message: Roe Peterson: "raid1 problems in 2.5.26 (maybe started at .1?)"
In reply to: Marcin Dalecki: "[PATCH] 2.5.27 read_write"
Next in thread: Marcin Dalecki: "[PATCH] 2.5.27 read_write - take 2"
Reply: Marcin Dalecki: "[PATCH] 2.5.27 read_write - take 2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Mon, 2002-07-22 at 15:08, Marcin Dalecki wrote:
> - It is fixing completely confused wild casting to 32 bits.
>
> - Actually adding a comment explaining the obscure code, which is
> relying on integer arithmetics overflow.

Better yet take the code from 2.4.19-rc3. The code you fixed up is still
wrong. Sincie iov_len is not permitted to exceed 2Gb (SuS v3, found by
the LSB test suite) the actual fix turns out to be even simpler and
cleaner than the one you did

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Arnaldo Carvalho de Melo: "Re: [2.5.27] Oops in tcp_v6_get_port"
Previous message: Roe Peterson: "raid1 problems in 2.5.26 (maybe started at .1?)"
In reply to: Marcin Dalecki: "[PATCH] 2.5.27 read_write"
Next in thread: Marcin Dalecki: "[PATCH] 2.5.27 read_write - take 2"
Reply: Marcin Dalecki: "[PATCH] 2.5.27 read_write - take 2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:39 EST