Re: [PATCH] 2.5.27 smbiod

From: Albert D. Cahalan (acahalan@cs.uml.edu)
Date: Mon Jul 22 2002 - 17:29:30 EST


Marcin Dalecki writes:

> Fix label at block end warning - don't write "assembler code".
...
> if (server->state != CONN_VALID)
> - goto out;
> + return;
...
> -
> -out:
> }

Assembler? No, that would be Pascal. Many would argue
that a return out of the middle is as ugly as a goto.

Maybe it doesn't matter, and maybe you did actually
improve the code generation, but there's an obvious
way to ditch the warning without changing so much.
Note the semicolon:

out:;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:40 EST