On Tue, Jul 23, 2002 at 01:34:37PM -0700, Patrick Mochel wrote:
>
> > Which stepping do you have ?
> 2.
I meant ->x86_model there, I assume you did too, and you have a 0xF24/0xF27 cpu.
I wasn't aware these were HT aware. In fact, only 0xF50 are confirmed.
Interesting.
> Sorry, it was in the invisible charset.
Ah ok. I'll install the correct font later.
> ===== arch/i386/kernel/cpu/intel.c 1.3 vs edited =====
> --- 1.3/arch/i386/kernel/cpu/intel.c Wed Jul 10 03:46:31 2002
> +++ edited/arch/i386/kernel/cpu/intel.c Tue Jul 23 13:25:01 2002
> @@ -232,15 +232,19 @@
> if (c->x86 == 6) {
> switch (c->x86_model) {
> case 5:
> - if (l2 == 0)
> - p = "Celeron (Covington)";
> - if (l2 == 256)
> - p = "Mobile Pentium II (Dixon)";
> + if (c->x86_mask == 0) {
> + if (l2 == 0)
> + p = "Celeron (Covington)";
> + else if (l2 == 256)
> + p = "Mobile Pentium II (Dixon)";
Something that just nagged me about this code.
Where are those strings stored ? If they're in the same
text as this code, we shouldn't be creating references to them,
as after boot, all this will go poof. (it's __init)
If they are stored there, a simple strdup/memcpy will fix it
of course, but I'm wondering if we even need to. Or does
our linker magic put strings in data sections ?
Dave
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:44 EST