Re: [PATCH] 2.5.27 fix potential spinlocking race.

From: Linus Torvalds (torvalds@transmeta.com)
Date: Tue Jul 23 2002 - 21:24:05 EST


On Tue, 23 Jul 2002, David S. Miller wrote:
>
> In case of socket transmission errors etc. kfree_skb(), and hence
> xprt_write_space() can potentially get called outside of a bh-safe
> context.
>
> kfree_skb must occur within a BH context or better context.

I think you're talking past each other.

Trond noticed that kfree_skb() can be called from a _non_ bh context, ie
process context. So it needs to protect itself against other bh's on this
CPU (which it wouldn't need to do if it was only called from a bh
context).

So it's exactly your "better context" that is at stake here.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Jul 23 2002 - 22:00:45 EST