alan@redhat.com said:
> Its not a veto. I was trying to avoid having to add any more branches
> to the fast paths in the kernel.
Unless I'm missing something, a test for altmm and a branch to out of line
mm switching should be about three instructions on x86 including a correctly
predicted branch not taken in the non-altmm case.
> The remaining sigreturn question is
> "how do you get into 'user' mode the first time"
Last night I told you it was by building a signal frame by hand and returning
through it. That's no longer true. Now, every UML thread (except the idle
thread, which I think can be reasonable expected not to try to enter userspace)
is in a host signal handler when in the kernel.
All entrances to userspace happen by returning through that signal frame.
Special userspace returns (exec and fork et al) fiddle the sigcontext in
that frame beforehand. Normal system calls stuff the return value in the
appropriate slot in the sigcontext before returning, as well.
So, there's nothing special about entering userspace for the first time.
Everything is under a signal frame, so any time something needs to enter
userspace, it just returns through it.
> This switches to the altmm (creating one if it doesnt exist as a copy
> of the current mm)
About this business of creating a UML kernel address space for each UML
user thread - I prefer to have a single kernel address space to which all
signals are delivered.
This has the slight disadvantage that the process address space isn't directly
accessible, but I can live with that. A virt_to_phys translation isn't too
painful.
A single separate kernel address space has the following attractions for me:
there are some cases where 3G of KVA would be very useful
it would make the UML kernel completely invisible to processes, which
is important for honeypots
apps which consume huge amounts of VM might run on the host, but
crap out inside a UML
This raises the question of how the process address spaces are created. For
a variety of reasons unrelated to altmm (which I can go into if anyone's
interested), I want address spaces to be separate user-visible objects.
You'd create a new empty one by opening /proc/new-mm or something and get
back a file descriptor as a handle to it. mmap/munmap/mprotect would be
extended to take a file descriptor pointing to the address space to be
changed.
So, altmm would look like this:
When it starts up, UML would call sigaltmm, passing a descriptor to its own
address space and register its signal handlers with a new flag, SA_IN_MM.
sigaction would have an mm field in which this descriptor would be put (and
would contain -1 in the non-altmm case).
The sigcontext would have an extra int in it which would be the descriptor
of the address space to which sigreturn will return.
Like now, UML would arrange that everything is under a host signal handler.
When it enters userspace it would change the address space fd in the sigcontext
if necessary.
Does this sound sane?
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:20 EST