Re: [PATCH] 2.5.30 IDE 113

From: Jens Axboe (axboe@suse.de)
Date: Tue Aug 06 2002 - 05:42:38 EST


On Tue, Aug 06 2002, Marcin Dalecki wrote:
> device not per channel! If q->request_fn would properly return the
> error count instead of void, we could even get rid ot the
> checking for rq->errors after finishment... But well that's
> entierly different story.

That's nonsense! What exactly would you return from a request_fn after
having queued, eg, 20 commands? Error count is per request, anything
else would be stupid.

-- 
Jens Axboe

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:30 EST