Re: [PATCH] [2.5 i386] Fix AP GDT descs to have limit = size - 1

From: Ingo Molnar (mingo@elte.hu)
Date: Wed Aug 07 2002 - 11:53:44 EST

Next message: Andries Brouwer: "Re: Why 'mrproper'?"
Previous message: Tom Rini: "[PATCH][RESEND x 2] A generic RTC driver [3/3]"
In reply to: Luca Barbieri: "[PATCH] [2.5 i386] Fix AP GDT descs to have limit = size - 1"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 7 Aug 2002, Luca Barbieri wrote:

> memcpy(cpu_gdt_table[cpu], cpu_gdt_table[0], GDT_SIZE);
> - cpu_gdt_descr[cpu].size = GDT_SIZE;
> + cpu_gdt_descr[cpu].size = GDT_SIZE - 1;
> cpu_gdt_descr[cpu].address = (unsigned long)cpu_gdt_table[cpu];

indeed, good eyes!

i'm wondering whether this could have caused any problems - since the
limit was not a proper multiple of 8 minus 1, no selector value could have
caused a descriptor to be loaded from the invalid byte.

Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Andries Brouwer: "Re: Why 'mrproper'?"
Previous message: Tom Rini: "[PATCH][RESEND x 2] A generic RTC driver [3/3]"
In reply to: Luca Barbieri: "[PATCH] [2.5 i386] Fix AP GDT descs to have limit = size - 1"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:36 EST