Re: [PATCH] conditionally re-enable per-disk stats, convert to seq_file

From: Kurt Garloff (kurt@garloff.de)
Date: Wed Aug 07 2002 - 16:02:25 EST

Hi Christoph,

On Tue, Aug 06, 2002 at 04:08:48PM +0200, Christoph Hellwig wrote:
> This patch against 2.4.20-pre1 converts /proc/partitions to the seq_file
> interface as in 2.5, makes it report the sard-style extended disk
> statistics condititional on CONFIG_BLK_STATS and disables the gathering
> of those totally otherwise to not waste memory and processing power.
>
> This patch is based on the concept of Kurt's statistics patch, although
> it is implemented very differently to avoid #ifdef hell.

Actually, I was expecting criticism due to the ifdef stuff I did and was
prepared to come up with something better. But I also learned never to put
effort into something before being asked to ...

Your patch looks fine to me. Thanks for preparing it!

Regards, 

-- 
Kurt Garloff                   <kurt@garloff.de>         [Eindhoven, NL]
Physics: Plasma simulations    <K.Garloff@TUE.NL>     [TU Eindhoven, NL]
Linux: SCSI, Security          <garloff@suse.de>    [SuSE Nuernberg, DE]
 (See mail header or public key servers for PGP2 and GPG public keys.)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Wed Aug 07 2002 - 22:00:38 EST