Re: [PATCH] cpumask_t

From: David S. Miller (davem@redhat.com)
Date: Thu Aug 08 2002 - 09:36:30 EST


   From: Rusty Russell <rusty@rustcorp.com.au>
   Date: Thu, 08 Aug 2002 17:39:18 +1000

   I've tested this now with making cpumask_t a struct, and it works fine
   (at the moment it's unsigned long for every arch, no change).

It worked because you cast the thing to (unsigned long *) in every
bitops. We either:

1) shouldn't need to do that, meaning cpumask_t must be a long
   or array or longs

2) you need to abstract away bitops on cpumask_t so that one
   _really_ could make cpumask_t a struct with things other
   than the mask itself inside, so cpumask_test, cpumask_add,
   cpumask_remove or however you'd like to name them

Didn't we go through a lot of effort to sanitize bitops types
and kill the ugly casts? :-))))

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:16 EST