Re: [patch 6/12] hold atomic kmaps across generic_file_read

From: Linus Torvalds (torvalds@transmeta.com)
Date: Sat Aug 10 2002 - 12:03:09 EST


On Sat, 10 Aug 2002, Rik van Riel wrote:
> On Sat, 10 Aug 2002, Linus Torvalds wrote:
>
> > and having it magically populate the VM directly with the whole file
> > mapping, with _one_ failed page fault. And the above is actually a fairly
> > common thing. See how many people have tried to optimize using mmap vs
> > read, and what they _all_ really wanted was this "populate the pages in
> > one go" thing.
>
> If this is worth it, chances are prefaulting at mmap() time
> could also be worth trying ... hmmm ;)

Maybe, maybe not.

The advantage of read() is that it contains an implicit "madvise()", since
the read _tells_ us that it wants X pages.

A page fault does not tell us, and prefaulting can hurt us.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:22 EST