On Sun, Aug 11, 2002 at 02:48:23AM -0700, Andrew Morton wrote:
> Andi Kleen wrote:
> >
> > Andrew Morton <akpm@zip.com.au> writes:
> > > */
> > > -void lru_cache_add(struct page * page)
> > > +static struct pagevec lru_add_pvecs[NR_CPUS];
> > > +
> > > +void lru_cache_add(struct page *page)
> > > +{
> > > + struct pagevec *pvec = &lru_add_pvecs[get_cpu()];
> >
> > This should probably use the linux/percpu.h macros.
> > This way it could be more efficient on some architectures and also avoid
> > potential false sharing.
>
> Yes, I need to do a sweep sometime and convert some things like
> that. Preferably after the hot-remove APIs are there. Or is
> that not planned?
I would see them as independent problems. No need to stall one by the other.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:24 EST