Re: [kbuild-devel] [patch] config language dep_* enhancements

From: Greg Banks (gnb@alphalink.com.au)
Date: Mon Aug 12 2002 - 05:38:35 EST


Andreas Schwab wrote:
>
> |> > + case "$arg" in
> |> > + y|m|n) ;;
> |> > + *) arg=$(eval echo \$$arg) ;;
> |>
> |> Don't you want to check at this point that arg starts with CONFIG_?
> |> Also, how about quoting \$$arg ?
>
> The Right Way to write that is like this, assuming that $arg has already
> been verified to be a valid identifier:

Yes, assuming that happens...

> eval arg=\$$arg
>
> No need for further quoting.

you're right.

Greg.

-- 
the price of civilisation today is a courageous willingness to prevail,
with force, if necessary, against whatever vicious and uncomprehending
enemies try to strike it down.     - Roger Sandall, The Age, 28Sep2001.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:27 EST