Re: [PATCH][RFC] sigurg/sigio cleanup for 2.5.31

• Next message: Partha Narayanan: "smptimers - performance impact"
• Previous message: John Lenton: "bug affecting 2.4.x's /proc/stat's disk_io"
• In reply to: James Morris: "[PATCH][RFC] sigurg/sigio cleanup for 2.5.31"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello!

> Comments welcome.

I do not know what forced you to use BKL.

But I daresay this is deadlock:

+ lock_kernel();
+ error = f_setown(filp, current->pid);
+ unlock_kernel();
        if (error) {
                write_unlock(&dn_lock);
                return error;

Use of BKL when another spin lock is grabbed... It will deadlock
each time when some dcahe op is made under BKL.

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Partha Narayanan: "smptimers - performance impact"
• Previous message: John Lenton: "bug affecting 2.4.x's /proc/stat's disk_io"
• In reply to: James Morris: "[PATCH][RFC] sigurg/sigio cleanup for 2.5.31"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 15 2002 - 22:00:40 EST