Re: Little console problem in 2.5.30

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Mon Aug 19 2002 - 07:36:25 EST

On Mon, 19 Aug 2002, Pete Zaitcev wrote:
> I would appreciate if someone would explain me if the attached patch
> does the right thing. The problem is that I do not use the framebuffer,
> and use a serial console. Whenever a legacy /sbin/init tries to
> open /dev/tty0, the system oopses dereferencing conswitchp in
> visual_init().

And this worked before?

conswitchp must never be NULL, say `conswitchp = &dummy_con;' in your setup.c
if you have a serial console.

>From looking at arch/sparc/kernel/setup.c, perhaps you have
CONFIG_DUMMY_CONSOLE=n?

> -- Pete
>
> diff -ur -X dontdiff linux-2.5.30-sp_pbk/drivers/char/console.c linux-2.5.30-sparc/drivers/char/console.c
> --- linux-2.5.30-sp_pbk/drivers/char/console.c Thu Aug 1 14:16:34 2002
> +++ linux-2.5.30-sparc/drivers/char/console.c Sun Aug 18 23:14:20 2002
> @@ -652,7 +652,7 @@
>
> int vc_allocate(unsigned int currcons) /* return 0 on success */
> {
> - if (currcons >= MAX_NR_CONSOLES)
> + if (currcons >= MAX_NR_CONSOLES || conswitchp == NULL)
> return -ENXIO;
> if (!vc_cons[currcons].d) {
> long p, q;

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Fri Aug 23 2002 - 22:00:17 EST