Re: [patch] (re)implement setkeycode/getkeycode/kd_mksound/kbd_setrate via the input core

• Next message: Louis Garcia: "linux ata list?"
• Previous message: Alan Cox: "Re: packet re-ordering on SMP machines."
• Maybe in reply to: Vojtech Pavlik: "[patch] (re)implement setkeycode/getkeycode/kd_mksound/kbd_setrate via the input core"
• Next in thread: Vojtech Pavlik: "[patch] Stricter checks in [gs]etkeycode, recompute keybit there also"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This bit looks wrong to me:

+ for (handle = kbd_handler.handle; handle; handle = handle->hnext)
+ if (handle->dev->keycodesize) break;
+
+ if (!handle->dev->keycodesize)
+ return -ENODEV;

if we reach termination for the loop without finding a keycodesize, handle
will be NULL, so you'd get an oops. Just do:

+ if (!handle)
+ return -ENODEV

(sorry about the formatting, i'm reading l-k via uwsg's web archive).

-- 
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Louis Garcia: "linux ata list?"
• Previous message: Alan Cox: "Re: packet re-ordering on SMP machines."
• Maybe in reply to: Vojtech Pavlik: "[patch] (re)implement setkeycode/getkeycode/kd_mksound/kbd_setrate via the input core"
• Next in thread: Vojtech Pavlik: "[patch] Stricter checks in [gs]etkeycode, recompute keybit there also"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:15 EST