Re: Bug in kernel code?

From: Luca Barbieri (ldb@ldb.ods.org)
Date: Tue Aug 27 2002 - 23:29:59 EST

Next message: Randy.Dunlap: "Re: [PATCH] XFree v4.2.x DRM/DRI Support for 2.4.20-pre4"
Previous message: James Morris: "[PATCH] sigio/sigurg cleanup for 2.5.32 (fwd)"
In reply to: David S. Miller: "Re: Bug in kernel code?"
Next in thread: Stephen Biggs: "Re: Bug in kernel code?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 2002-08-28 at 06:07, David S. Miller wrote:
> From: Luca Barbieri <ldb@ldb.ods.org>
> Date: 28 Aug 2002 06:10:39 +0200
>
> I'm not saying that it's serious bug, just that using __ffs is more
> appropriate than reimplementing it incorrectly and inefficiently.
>
> ffs won't find the smallest power of 2 >= some_arbitrary_value.
> That is what this code is doing.
Yes you are right, fls should be used there, not ffs.

application/pgp-signature attachment: This is a digitally signed message part

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Randy.Dunlap: "Re: [PATCH] XFree v4.2.x DRM/DRI Support for 2.4.20-pre4"
Previous message: James Morris: "[PATCH] sigio/sigurg cleanup for 2.5.32 (fwd)"
In reply to: David S. Miller: "Re: Bug in kernel code?"
Next in thread: Stephen Biggs: "Re: Bug in kernel code?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:22 EST