Re: input u-cleanup

• Next message: Andre Hedrick: "Re: My /dev/hda became /dev/hde after upgrading"
• Previous message: Rusty Russell: "Re: [PATCH] list.h update (resent again)"
• In reply to: Pavel Machek: "input u-cleanup"
• Next in thread: Pavel Machek: "Re: input u-cleanup"
• Reply: Pavel Machek: "Re: input u-cleanup"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Aug 29, 2002 at 12:06:03AM +0200, Pavel Machek wrote:
> Hi!
>
> proc is clever enough not to need ifdefs, so this is probably good
> idea...
>
> Pavel

If you could remove all the procfs #ifdefs from input.c, that'd be great.
But removing only those around unregistration IMHO doesn't make sense.

>
> --- clean/drivers/input/input.c Wed Aug 28 22:38:46 2002
> +++ linux-swsusp/drivers/input/input.c Wed Aug 28 23:28:23 2002
> @@ -800,11 +803,9 @@
>
> static void __exit input_exit(void)
> {
> -#ifdef CONFIG_PROC_FS
> remove_proc_entry("devices", proc_bus_input_dir);
> remove_proc_entry("handlers", proc_bus_input_dir);
> remove_proc_entry("input", proc_bus);
> -#endif
> devfs_unregister(input_devfs_handle);
> if (unregister_chrdev(INPUT_MAJOR, "input"))
> printk(KERN_ERR "input: can't unregister char major %d", INPUT_MAJOR);
>
> --
> Worst form of spam? Adding advertisment signatures ala sourceforge.net.
> What goes next? Inserting advertisment *into* email?

-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

• Next message: Andre Hedrick: "Re: My /dev/hda became /dev/hde after upgrading"
• Previous message: Rusty Russell: "Re: [PATCH] list.h update (resent again)"
• In reply to: Pavel Machek: "input u-cleanup"
• Next in thread: Pavel Machek: "Re: input u-cleanup"
• Reply: Pavel Machek: "Re: input u-cleanup"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Aug 31 2002 - 22:00:25 EST