__pa(vmalloc()) considered harmful?

From: Jeff Dike (jdike@karaya.com)
Date: Tue Sep 03 2002 - 20:07:05 EST


It sure doesn't make sense to me, but that's effectively what
elf_kcore_store_hdr does:

        for (m=vmlist; m; m=m->next) {
                [ snip ]
                phdr->p_paddr = __pa(m->addr);
                [ snip ]
        }

This doesn't actually hurt when __pa(addr) == addr - $SOMETHING, but it
does produce meaningless numbers.

It does hurt when your __pa() is something more complicated and it can
tell that it's being asked to do something stupid.

So what's p_paddr supposed to be, anyway?

                                Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 07 2002 - 22:00:19 EST