Re: [PATCH] highmem I/O for ide-pmac.c

From: Jens Axboe (axboe@suse.de)
Date: Wed Sep 11 2002 - 08:07:54 EST

On Wed, Sep 11 2002, Jens Axboe wrote:
> Also, can you grow sg segments indefinitely?

Maybe you copied that from ide-dma? I think it would be safer to just
remove it, btw, there's no (if any) benefit to making the sg segments
bigger than a page since we'll much sooner hit the max sectors
limitation than the segment one.

Marcelo, please apply.

--- drivers/ide/ide-dma.c~ 2002-09-11 15:06:48.000000000 +0200
+++ drivers/ide/ide-dma.c 2002-09-11 15:07:26.000000000 +0200
@@ -268,15 +268,6 @@
                 struct scatterlist *sge;
 
                 /*
- * continue segment from before?
- */
- if (bh_phys(bh) == lastdataend) {
- sg[nents - 1].length += bh->b_size;
- lastdataend += bh->b_size;
- continue;
- }
-
- /*
                  * start new segment
                  */
                 if (nents >= PRD_ENTRIES) 

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:25 EST