Re: 2.5.34: IR __FUNCTION__ breakage

From: Andreas Steinmetz (ast@domdv.de)
Date: Fri Sep 13 2002 - 13:01:14 EST


(rct@gherkin.frus.com removed from cc list as his mta treats (not only)
my mails as spam...)

Ahmed Masud wrote:
> Thunder from the hill wrote:
>
>> Hi,
>>
>> On Fri, 13 Sep 2002, Andreas Steinmetz wrote:
>>
>>> At least for gcc 3.2 this would be better:
>>>
>>> #define DERROR(dbg, fmt, args...) \
>>> do { if (DEBUG_##dbg) \
>>> printk(KERN_INFO "irnet: %s(): " fmt, __FUNCTION__, ##args); \
>>> } while(0)
>>>
> Perhaps a hybrid of the two? :
>
> #define DERROR(dbg, fmt,
> args...) \
> do { if (DEBUG_##dbg) { \
> printk(KERN_INFO "irnet: %s() : ", __FUNCTION__); \
> printk(fmt, ## args); \
> } \
> } while (0)
>
>
How about what I did just suggest for smbfs?

#if __GNUC__>=3
#define DERROR(dbg, fmt, args...) \
   do { if (DEBUG_##dbg) \
       printk(KERN_INFO "irnet: %s(): " fmt, __FUNCTION__, ##args); \
   } while(0)
#else
#define DERROR(dbg, args...) \
   {if(DEBUG_##dbg) \
     printk(KERN_INFO "irnet: " __FUNCTION__ "(): " args);}
#endif

gcc 2 versions will be deprecated eventually some time in the future and
in between the macro selection by gcc major version should be fair enough.

-- 
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Sep 15 2002 - 22:00:34 EST