Re: [PATCH] Fix for ptrace breakage

From: OGAWA Hirofumi (hirofumi@mail.parknet.co.jp)
Date: Mon Sep 16 2002 - 06:58:53 EST

Ingo Molnar <mingo@elte.hu> writes:

> On Mon, 16 Sep 2002, OGAWA Hirofumi wrote:
>
> > list_for_each(_p, &father->ptrace_children) {
> > p = list_entry(_p,struct task_struct,ptrace_list);
> > list_del_init(&p->ptrace_list);
> > reparent_thread(p, reaper, child_reaper);
> > if (p->parent != p->real_parent)
> > list_add(&p->ptrace_list, &p->real_parent->ptrace_children);
> > }
> >
> > current->ptrace_children should be empty after this reparent.
>
> oh, okay. It's also cleaner this way.

Grr, sorry. This patch is bad version.

         list_for_each(_p, &father->ptrace_children) {

of course, this should

         list_for_each_safe(_p, _n, &father->ptrace_children) {

I'll resend patch. 

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:16 EST