Re: linux-2.5.36 Oops on power-down

From: Russell King (rmk@arm.linux.org.uk)
Date: Thu Sep 19 2002 - 05:41:15 EST


On Wed, Sep 18, 2002 at 04:01:53PM -0700, Patrick Mochel wrote:
> It appears that the 8250_pci serial driver needs a check for NULL when
> calling the device's re-init function. Could you try the attached patch
> and let us know if it works for you?

The patch is correct. Linus, please apply.

===== drivers/serial/8250_pci.c 1.8 vs edited =====
--- 1.8/drivers/serial/8250_pci.c Mon Jul 29 07:52:41 2002
+++ edited/drivers/serial/8250_pci.c Wed Sep 18 15:51:32 2002
@@ -771,7 +771,8 @@
                 for (i = 0; i < priv->nr; i++)
                         unregister_serial(priv->line[i]);
 
- priv->board->init_fn(dev, priv->board, 0);
+ if (priv->board->init_fn)
+ priv->board->init_fn(dev, priv->board, 0);
 
                 pci_disable_device(dev);
 

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Sep 23 2002 - 22:00:26 EST