> +#include <linux/version.h>
shouldn't be needed
> +#include <linux/kernel.h>
> +#include <linux/slab.h>
> +#include <asm/atomic.h>
> +#include <linux/fs.h>
> +#include <linux/posix_acl.h>
> +#include <linux/module.h>
> +
> +#include <linux/smp_lock.h>
not needed
> +MODULE_AUTHOR("Andreas Gruenbacher <a.gruenbacher@computer.org>");
> +MODULE_DESCRIPTION("Generic Posix Access Control List (ACL) Manipulation");
> +MODULE_LICENSE("GPL");
looks pretty pointless as this can't be a module.. :)
> +struct posix_acl *
> +get_posix_acl(struct inode *inode, int type)
> +{
> + struct posix_acl *acl;
> +
> + if (!inode->i_op->get_posix_acl)
> + return ERR_PTR(-EOPNOTSUPP);
> + down(&inode->i_sem);
> + acl = inode->i_op->get_posix_acl(inode, type);
> + up(&inode->i_sem);
> +
> + return acl;
> +}
> +
> +/*
> + * Set the POSIX ACL of an inode.
> + */
> +int
> +set_posix_acl(struct inode *inode, int type, struct posix_acl *acl)
> +{
> + int error;
> +
> + if (!inode->i_op->set_posix_acl)
> + return -EOPNOTSUPP;
> + down(&inode->i_sem);
> + error = inode->i_op->set_posix_acl(inode, type, acl);
> + up(&inode->i_sem);
> +
> + return error;
> +}
> diff -Nru a/include/linux/fs.h b/include/linux/fs.h
> --- a/include/linux/fs.h Wed Oct 9 23:53:33 2002
> +++ b/include/linux/fs.h Wed Oct 9 23:53:33 2002
> @@ -770,6 +770,9 @@
> unsigned long (*get_unmapped_area)(struct file *, unsigned long, unsigned long, unsigned long, unsigned long);
> };
>
> +/* posix_acl.h */
> +struct posix_acl;
> +
> struct inode_operations {
> int (*create) (struct inode *,struct dentry *,int);
> struct dentry * (*lookup) (struct inode *,struct dentry *);
> @@ -791,6 +794,8 @@
> ssize_t (*getxattr) (struct dentry *, const char *, void *, size_t);
> ssize_t (*listxattr) (struct dentry *, char *, size_t);
> int (*removexattr) (struct dentry *, const char *);
> + struct posix_acl *(*get_posix_acl) (struct inode *, int);
> + int (*set_posix_acl) (struct inode *, int, struct posix_acl *);
Either you make all setting/retrieving of ACLs go through this interface or
just rip it. We don't need more than one way to fiddle with ACLs.
Also they should take dentries..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:38 EST