On Mon, Oct 14, 2002 at 01:54:52PM +0000, Adam Belay wrote:
>
> PNP SUPPORT
> -P: Tom Lees
> -M: tom@lpsg.demon.co.uk
> -L: pnp-users@ferret.lmh.ox.ac.uk
> -L: pnp-devel@ferret.lmh.ox.ac.uk
> -W: http://www-jcr.lmh.ox.ac.uk/~pnp/
> +P: Adam Belay
> +M: ambx1@neo.rr.com
> S: Maintained
Any word from the people I pointed you at last time?
> +#ifdef __PNP__
No, don't redefine CONFIG variables. What's wrong with using
CONFIG_PNP?
> +static const struct pnp_id pnp_dev_table[] = {
> + /* Standard LPT Printer Port */
> + { "PNP0400", 0 },
Using named initializers are preferred.
> + /* ECP Printer Port */
> + { "PNP0401", 0 },
> + { "", 0 }
> +};
> +
> +/* we only need the pnp layer to activate the device, at least for now */
> +static struct pnp_driver parport_pc_pnp_driver = {
> + .name = "parport_pc",
> + .card_id_table = NULL,
> + .id_table = pnp_dev_table,
> +};
> +#endif
> +
> /* This is called by parport_pc_find_nonpci_ports (in asm/parport.h) */
> static int __init __attribute__((unused))
> parport_pc_find_isa_ports (int autoirq, int autodma)
> @@ -3020,6 +3038,10 @@
>
> int __init parport_pc_init (int *io, int *io_hi, int *irq, int *dma)
> {
> +#ifdef __PNP__
> + /* try to activate any PnP parports first */
> + pnp_register_driver(&parport_pc_pnp_driver);
> +#endif
pnp_register_driver() should be implemented so that you don't need a
#ifdef around it to call it. Put the #ifdef in the header file.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:51 EST