Re: patch for 2.5.42. 2/2

From: Pavel Machek (pavel@suse.cz)
Date: Mon Oct 14 2002 - 11:52:02 EST


Hi!

> > --- linux-2.5.42/drivers/net/3c59x.c Sat Oct 12 21:25:00 2002
> > +++ linux-2.5.42-suspend/drivers/net/3c59x.c Sat Oct 12 21:20:48 2002
>
> > +#ifdef CONFIG_PM
> > + int in_suspend;
> > +#endif
>
> This looks like a serious design mistake. Surely it would be
> better to just have the network layer stop operations when the
> system is going into suspend, instead of having to modify 100
> individual network drivers ?

Whole userland is stopped at that point. That should mean that new
requests can not come.

OTOH packet from the network *can* come, and higher levels can not do
much with that. [They could ifconfig down the network interface... But
that can have sideefects we don't want to see...]

                                                                Pavel

-- 
When do you have heart between your knees?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:54 EST