Re: [PATCH] Re: [PATCH] async poll for 2.5

From: John Gardiner Myers (jgmyers@netscape.com)
Date: Tue Oct 15 2002 - 13:16:22 EST


This looks better, but there are still some issues:

The patch arrived here with tabs expanded into spaces, so it doesn't apply.

The EAGAIN fix by Mingming Cao is obviously incomplete, as I've
mentioned in a separate message to linux-aio. I think it would be
better if you would leave this out of this patch and let it be handled
separately.

async_poll_complete() is dead code and should be removed (this was an
issue in the original 2.4.19 code).

You should not reintroduce the ki_data member of struct iocb. Insead
you should use the existing private member of struct iocb.

In aio_abi.h, you should adjust the preceeding comment to remove mention
of IOCB_CMD_POLL.

Incidentally, this patch depends on the sys_io_cancel() portion of the
patch I posted yesterday in order for cancellation to return the correct
result to user space.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:56 EST