Re: [patch] futex-2.5.42-A2

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Tue Oct 15 2002 - 21:26:02 EST

Next message: Michael Clark: "Re: [Kernel 2.5] Qlogic 2x00 driver"
Previous message: Charles 'Buck' Krasic: "Re: [PATCH] async poll for 2.5"
In reply to: Ingo Molnar: "[patch] futex-2.5.42-A2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <Pine.LNX.4.44.0210152157001.21066-100000@localhost.localdomain> you
write:
> - simplified alignment check in sys_futex. (Martin Wirth)

Um, this test existed for a reason:

> - /* Must be "naturally" aligned, and not on page boundary. */
> - if ((pos_in_page % __alignof__(int)) != 0
> - || pos_in_page + sizeof(int) > PAGE_SIZE)
> + /* Must be "naturally" aligned */
> + if (pos_in_page % sizeof(int))
> return -EINVAL;

If you do this, *please* add:
        /* Above check not sufficient if align of int < size. Break link. */
        if (__alignof__(int) < sizeof(int)) {
                extern void __error_small_int_align();
                __error_small_int_align();
        }

Cheers,
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Michael Clark: "Re: [Kernel 2.5] Qlogic 2x00 driver"
Previous message: Charles 'Buck' Krasic: "Re: [PATCH] async poll for 2.5"
In reply to: Ingo Molnar: "[patch] futex-2.5.42-A2"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Oct 15 2002 - 22:00:59 EST