Re: [PATCH][RFC] add support for PC-9800 architecture (20/26) serial #1

From: Andrey Panin (pazke@orbita1.ru)
Date: Fri Oct 18 2002 - 01:06:11 EST


On Thu, Oct 17, 2002 at 03:11:25PM +0100, Russell King wrote:
> I strongly recommend _n_o_t_ merging this patch.

Did you see the next patch (21/26 serial #2) ? It looks even more interesting.
As I understand serial98.c driver should support older i8251 UART.
However it does it by perverting 8250.c and EMULATING i8250 on top of i8251,
see ugly code in serial_in() and serial_out() functions.

May be I misunderstand the issue, but IMHO this patch is unacceptible too :(

Best regards.
 

-- 
Andrey Panin            | Embedded systems software developer
pazke@orbita1.ru        | PGP key: wwwkeys.eu.pgp.net


- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Oct 23 2002 - 22:00:40 EST