Re: [PATCH ] POSIX clocks & timers take 10 (NOT HIGH RES)

From: Randy.Dunlap (rddunlap@osdl.org)
Date: Mon Nov 11 2002 - 19:10:13 EST

Next message: Michael Hohnbaum: "Re: [PATCH 2.5.47] NUMA scheduler (1/2)"
Previous message: Andrew Morton: "Re: [BENCHMARK] 2.5.47{-mm1} with contest"
Next in thread: george anzinger: "Re: [PATCH ] POSIX clocks & timers take 10 (NOT HIGH RES)"
Reply: george anzinger: "Re: [PATCH ] POSIX clocks & timers take 10 (NOT HIGH RES)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi George,

I have a couple of small comments on the latest POSIX interface
patch (take 10 -- NOT HIGH RES).

1. arch/i386/kernel/entry.S uses nr_syscalls and the patch
removes NR_syscalls from include/asm-i386/sys.h, but
user-mode-linux needs/uses NR_syscalls. However, I see why you
removed it from sys.h: it's basically a dead file.
And it looks like include/linux/sys.h shouldn't have that
#define in it (should be per arch).

2. again in arch/i386/kernel/entry.S: the added syscall number
/*comments*/ are off by 1.

-- ~Randy

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Michael Hohnbaum: "Re: [PATCH 2.5.47] NUMA scheduler (1/2)"
Previous message: Andrew Morton: "Re: [BENCHMARK] 2.5.47{-mm1} with contest"
Next in thread: george anzinger: "Re: [PATCH ] POSIX clocks & timers take 10 (NOT HIGH RES)"
Reply: george anzinger: "Re: [PATCH ] POSIX clocks & timers take 10 (NOT HIGH RES)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:24 EST