arndb@de.ibm.com said:
> You can easily keep out the pci stuff if you do something like this:
No...look at what you've done. Now SCSI has to know about every bus type on
every architecture; that's an extreme layering violation. architecture/bus
types are generally only defined for the arch (PCI being the exception), so
now the additions have to be #ifdef'd just so it will compile..
You've done this because you effectively have to pull a common but differently
located structure element out of each of these bus specific devices. That
implies to me that dma_mask should be in a common structure, which was the
whole basis for the dmaable_device that I outlined previously. As I said, the
only reason I haven't implemented dmaable_device is for expediency.
James
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:17 EST