On Sun, 17 Nov 2002, Matthew Wilcox wrote:
>
> I'm quite happy to test that my header cleanups don't break things --
> but there are many things which don't currently compile anyway. I try
> to enable the things I think my changes will break, but I didn't spot
> the isapnp one my pci_dev changes broke. Could I ask that you update
> defconfig with your .config again so we can be sure things don't break
> _your_ build?
Breaking my build is ok, I can trivially fix those. Usually it's a
one-liner, and that's not the thing I worry about.
I worry about the fact that I'm aboud to releaser 2.5.48, and then it
doesn't compile for some silly reason, even though I've obviously tested
it on my configurations and fixed the problems _I_ saw.
Cleaning up header files is fine, but the trivial part is to remove the
line that includes another header file. The _real_ work is trying to
figure out that nothing else broke as a result, and I think that's what a
janitor who does these things should really care about.
The whole "janitor" name to me implies somebody who does the hand and ugly
and mostly boring thing that needs to be done to clean stuff up and make
sure things work smoothly. A "janitorial" patch that leaves broken pieces
in random places of the tree doesn't sound very janitorial to me, if you
see what I mean..
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:19 EST