Re: [PATCH] interrupt.h needs <asm/system.h>

From: Pete Zaitcev (zaitcev@redhat.com)
Date: Mon Nov 18 2002 - 14:01:58 EST


><asm/system.h> is needed for smp_mb(). Apparently this definition is pulled in
> some other way on ia32.
>
> --- linux-2.5.48/include/linux/interrupt.h Mon Nov 18 10:04:00 2002
> +++ linux-m68k-2.5.48/include/linux/interrupt.h Mon Nov 18 15:35:14 2002
> @@ -8,6 +8,7 @@
> #include <asm/hardirq.h>
> #include <asm/ptrace.h>
> #include <asm/softirq.h>
> +#include <asm/system.h>
>
> struct irqaction {
> void (*handler)(int, void *, struct pt_regs *);

Geert's patch looks correct to me.

By the way, I am curious, why do we never comment why a header
was included, like so: "#include <asm/system.h> /* smp_mb */"?
I suspect people are afraid that the comments get stale.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:23 EST