Rusty Russell wrote:
> Q: When does try_module_get(owner) fail?
> A: When the module is not ready to be entered (ie. still in
> init_module) or it is being removed. It fails to prevent you
> entering the module as it is being discarded (init might fail, or
> it's being removed).
I'd suggest "It fails in order to [...]" to avoid the "does work
exactly NOT as advertised" ambiguity ;-)
> Q: But modules call my register() routine which wants to call back
> into one of the function pointers immediately, and so
> try_module_get() fails!
> A: You're being called from the module, so someone already has a
> reference (unless there's a bug), so you don't need a
> try_module_get().
Hmm, I haven't really looked at your new code, but this sounds as
if try_module_get gets an exclusive lock. Is this true ? Doesn't
seem to make sense to me.
> Hope that helps?
Don't you want to repeat the golden rule at the end, just as a
polite reminder ? :-) (Just kidding.)
- Werner
-- _________________________________________________________________________ / Werner Almesberger, Buenos Aires, Argentina wa@almesberger.net / /_http://www.almesberger.net/____________________________________________/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:26 EST