Re: [patch] remove magic numbers in block queue initialization

From: Andrew Morton (akpm@digeo.com)
Date: Tue Nov 19 2002 - 18:18:44 EST


Robert Love wrote:
>
> Andrew,
>
> Your less-requests patch signaled a way-too-many magic numbers alarm
> (not the patches fault, of course, but it pointed it out).
>
> Attached patch removes the minimum queue length, maximum queue length,
> factor of queue length that is number of batch requests, and the maximum
> number of batch request magic numbers and replaces them with defines and
> some comments.
>
> Look OK?
>

Spose so. Sometime soon these need to be per-queue rather than global,
and set to intelligent defaults by the driver and runtime tunable
via files in /whereveritsmounted.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:29 EST