[PATCH] Re: [CHECKER] 74 potential buffer overruns in 2.5.33

From: Rik van Riel (riel@conectiva.com.br)
Date: Tue Nov 19 2002 - 22:00:33 EST

Next message: David McIlwraith: "Re: spinlocks, the GPL, and binary-only modules"
Previous message: Rik van Riel: "Re: spinlocks, the GPL, and binary-only modules"
In reply to: Andy Chou: "[CHECKER] 74 potential buffer overruns in 2.5.33"
Next in thread: Jens Axboe: "Re: [CHECKER] 74 potential buffer overruns in 2.5.33"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 19 Nov 2002, Andy Chou wrote:

> [BUG] Clear cut.
> /home/acc/linux/2.5.33/drivers/scsi/advansys.c:5100:advansys_detect:
> ERROR:BUFFER:5100:5100:Array bounds error: ep->adapter_info[6] indexed
> with [6]
> ep->adapter_info[1] = asc_dvc_varp->cfg->adapter_info[1];
> ep->adapter_info[2] = asc_dvc_varp->cfg->adapter_info[2];
> ep->adapter_info[3] = asc_dvc_varp->cfg->adapter_info[3];
> ep->adapter_info[4] = asc_dvc_varp->cfg->adapter_info[4];
> ep->adapter_info[5] = asc_dvc_varp->cfg->adapter_info[5];
>
> Error --->
> ep->adapter_info[6] = asc_dvc_varp->cfg->adapter_info[6];
>
> /*
> * Modify board configuration.

Nice catch. The fix should be simple too, since the 7th field
doesn't seem to be referenced anywhere else in advansys.c.

Bob, does the attached trivial patch look ok to you ?

Rik

-- 
Bravely reimplemented by the knights who say "NIH".
http://www.surriel.com/		http://guru.conectiva.com/
Current spamtrap:  <a href=mailto:"october@surriel.com">october@surriel.com</a>
===== drivers/scsi/advansys.c 1.18 vs edited =====
--- 1.18/drivers/scsi/advansys.c	Tue Oct 15 16:13:00 2002
+++ edited/drivers/scsi/advansys.c	Wed Nov 20 01:00:08 2002
@@ -5100,7 +5100,6 @@
                 ep->adapter_info[3] = asc_dvc_varp->cfg->adapter_info[3];
                 ep->adapter_info[4] = asc_dvc_varp->cfg->adapter_info[4];
                 ep->adapter_info[5] = asc_dvc_varp->cfg->adapter_info[5];
-                ep->adapter_info[6] = asc_dvc_varp->cfg->adapter_info[6];
                /*
                 * Modify board configuration.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: David McIlwraith: "Re: spinlocks, the GPL, and binary-only modules"
Previous message: Rik van Riel: "Re: spinlocks, the GPL, and binary-only modules"
In reply to: Andy Chou: "[CHECKER] 74 potential buffer overruns in 2.5.33"
Next in thread: Jens Axboe: "Re: [CHECKER] 74 potential buffer overruns in 2.5.33"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:30 EST