Re: [PATCH] mii module broken under new scheme

From: Rusty Russell (rusty@rustcorp.com.au)
Date: Tue Nov 19 2002 - 16:38:52 EST


In message <3DDA7A30.4010403@pobox.com> you write:
> Matt Reppert wrote:
>
> > drivers/net/mii.c doesn't export module init/cleanup functions. That
> > means it
> > can't be loaded under the new module scheme. This patch adds do-nothing
> > functions for it, which allows it to load. (8139too depends on mii, so
> > without this I don't have network.)
>
> ahhh! I was wondering what was up, but since I was busy with other
> things I just compiled it into the kernel and continued on my way.
>
> That's a bug in the new module loader.

Yes. But the workaround of calling the module "unknown" isn't nice
either: just put "no_module_init;" in and be done with it (it's also a
big hint that the module doesn't do anything itself).

Richard Henderson, Kai and myself are discussing a post-link stage for
modules, which will allow us to add the .modname section at that time,
but 99% of the cases are already fixed.

Sorry for any trouble,
Rusty.

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:31 EST