[ cc trimmed a-plenty ]
On Tue, Nov 19, 2002 at 12:55:20PM -0500, Jeff Garzik wrote:
> >There is *NO* module that does this right now and can be considered even
> >close to working. The rule always has been "register yourself when you
> >are ready for use". You're trying to add this new "You can fail after
> >registering yourself" semantic for brain dead coders that can't write an
> >init function to save thier ass. My position is that in doing so, you
> >fuck all of us that do write a reasonable init sequence and handle our
> >error conditions. Plus, since this is a changes in semantics, you have
> >possibly 50 or 100 modules that rely on the old behaviour, and maybe a
> >few
> >that are broken in regards to registration ordering. I think you are
> >trying to fix the wrong group of modules here.
> >
> >So, to me, the answer is clear. The rule is hard and fast, you don't
> >hand
> >out your function pointers to other modules or the core kernel until you
> >are ready for them to be used. Don't muck with the module loader to
> >solve
> >the problem, fix the maybe 4 or 5 modules that might violate this rule.
>
>
>
> violently agreed. This has the potential for requiring an update of
> almost every driver in the kernel, does it not?
jeff, why not put some sample code in prominent public places
(kernel.org, or perhaps more appropriately kernelnewbies.org) that
provides examples of sane module code, since that appears to be
the problem here.
i ask you since i have a vague recollection of you mentioning
macro-fying all the nic drivers with m4 a while back, and to do this you
must have had some sort of basic skeleton to flesh out.
it won't help the idiots, but it may help people who are less than
intimate with the rules and regulations of lunix module authoring
(perhaps having come from a different OS).
j.
-- toyota power: http://indigoid.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:34 EST