Re: [PATCH] fix compile error in usb-serial.c

From: Geert Uytterhoeven (geert@linux-m68k.org)
Date: Thu Nov 21 2002 - 04:54:20 EST

On Tue, 19 Nov 2002, Linux Kernel Mailing List wrote:
> ChangeSet 1.872.3.6, 2002/11/18 18:34:46-08:00, bunk@fs.tum.de
>
> [PATCH] fix compile error in usb-serial.c
>
> drivers/usb/serial/usb-serial.c in 2.5.48 fails to compile with the
> following error:
>
> drivers/usb/serial/usb-serial.c:842: dereferencing pointer to incompletetype
>
> Is the following patch correct?
>
>
> # This patch includes the following deltas:
> # ChangeSet 1.872.3.5 -> 1.872.3.6
> # drivers/usb/serial/usb-serial.c 1.52 -> 1.53
> #
>
> usb-serial.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> diff -Nru a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
> --- a/drivers/usb/serial/usb-serial.c Wed Nov 20 10:04:59 2002
> +++ b/drivers/usb/serial/usb-serial.c Wed Nov 20 10:04:59 2002
> @@ -839,7 +839,7 @@
>
> length += sprintf (page+length, "%d:", i);
> if (serial->type->owner)
> - length += sprintf (page+length, " module:%s", serial->type->owner->name);
> + length += sprintf (page+length, " module:%s", module_name(serial->type->owner));
> length += sprintf (page+length, " name:\"%s\"", serial->type->name);
> length += sprintf (page+length, " vendor:%04x product:%04x", serial->vendor, serial->product);
> length += sprintf (page+length, " num_ports:%d", serial->num_ports);
> -

How can this be correct?

serial->type->owner is of type struct module *, not char *!

Gr{oetje,eeting}s,

                                                Geert 

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:35 EST