On Thu, 2002-11-21 at 10:33, Sam Ravnborg wrote:
> > ifdef CONFIG_VISWS
> > -MACHINE := mach-visws
> > +MACHINE_C := mach-visws
> > +MACHINE_H := mach-visws
> > else
> > -MACHINE := mach-generic
> > +MACHINE_C := mach-generic
> > +MACHINE_H := mach-generic
>
> No reason to have two different variables assigned the same value.
Actually, in some cases, such as summit, we only have one header file
that is different from generic. We don't want to replicate all the
generic .c files, So in that case MACHINE_C := mach-generic and
MACHINE_H := mach-summit.
There very well could be a better way to do this, but splitting up the
.h files which fall back to generic nicely, and the .c files which don't
seemed to make the most sense.
> If you are modifying this anyway consider something like:
> machine-y := mach-generic
> machine-$(CONFIG_VISWS) := mach-visws
>
> And then replace $(MACHINE) with $(machine-y).
> This makes it much cleaner to add summit for example.
I agree, it could be cleaned up. I'll see if I can't clean it up
further.
thanks for the feedback
-john
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:37 EST