Re: [PATCH] Beginnings of conpat 32 code cleanups

From: Larry McVoy (lm@bitmover.com)
Date: Fri Nov 22 2002 - 14:54:54 EST


> Make your compat stuff use u32/s32/u64 directly, instead of making up ugly
> new types that make no sense.

IMHO, the thing that the early Unix systems did wrong was to not have
u8, u16, u32, etc as basic ctypes in sys/types.h. And C should have
had a way to fake it if they weren't native.

Anyone who has ported a networking stack or worked on driver knows exactly
what I'm talking about.

And while I'm whining,

        assert(strlen(any typedef) < 8));

I like my stack variable declarations to line up. I despise some_long_name_t
typedefs with a passion.

-- 
---
Larry McVoy            	 lm at bitmover.com           http://www.bitmover.com/lm 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Nov 23 2002 - 22:00:41 EST